Add INFO log for admissions which aren't allowed #6086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweber019
force-pushed
the
feat/admission-log
branch
from
452af5e
to
e3bf5a4
Compare
Signed-off-by: David Weber <[email protected]>
dweber019
force-pushed
the
feat/admission-log
branch
from
e3bf5a4
to
7893b49
Compare
programmer04
previously approved these changes
Jun 7, 2024
|
|
|
|
|
@lahabana please sign CLA and we're good to go |
randmonkey
reviewed
Oct 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6086 +/- ##
=====================================
Coverage 74.1% 74.2%
=====================================
Files 202 202
Lines 20492 20539 +47
=====================================
+ Hits 15198 15244 +46
- Misses 4274 4287 +13
+ Partials 1020 1008 -12 ☔ View full report in Codecov by Sentry. |
randmonkey
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It will add a INFO log message when an admission isn't allowed. This helps debugging and monitoring.
Which issue this PR fixes:
Fixes #6084
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR